Conversation
dangzitou
force-pushed
the
fix/session-cwd-isolation
branch
from
September 24, 2026 19:23
ee2fd95 to
30966a7
Compare
Collaborator
|
Thank you for taking the time to submit this PR and for supporting Step-Code! We are temporarily not accepting pull requests, so we will not be able to proceed with this change at the moment. Please stay tuned for future updates. We appreciate your understanding and support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--continueby the session header's actualcwd, even in a default encoded directory. Two paths such asproject-aandproject/aencode to the same session directory and could previously select — and append to — each other's sessions.--session-dirpath, the cross-project append case, and the "only the other project has a session" case.listAllstays unscoped on purpose and the test pins that.Behavior change
Sessions whose header carries no
cwd(or whose recordedcwdno longer matches — e.g. after the project directory was renamed or moved) no longer appear inlistand are not resumed by--continue. They remain visible throughlistAll. Previously such files were resumable from any project whose encoded directory collided with theirs, which is exactly the bug being fixed.Verification
npm run check./test.sh— full workspace suite green (coding-agent: 274 files / 3496 tests, apps/cli: 624 tests).Fixes #156.